Fix GradingPrimary bypass and add support Python comparison for Grading data objects#1779
Merged
doug-walker merged 3 commits intoMar 23, 2023
Merged
Conversation
Signed-off-by: Rémi Achard <remiachard@gmail.com>
This was
linked to
issues
Mar 20, 2023
cedrik-fuoco-adsk
approved these changes
Mar 21, 2023
Signed-off-by: Rémi Achard <remiachard@gmail.com>
doug-walker
approved these changes
Mar 23, 2023
Collaborator
doug-walker
left a comment
doug-walker
left a comment
There was a problem hiding this comment.
Perfectly done. Thank you so much for helping us cross this off our todo list Remi!
cedrik-fuoco-adsk
pushed a commit
to autodesk-forks/OpenColorIO
that referenced
this pull request
Mar 24, 2023
…ng data objects (AcademySoftwareFoundation#1779) * Fix GradingPrimary bypass, support comparison in Python Signed-off-by: Rémi Achard <remiachard@gmail.com> * Improve test description Signed-off-by: Rémi Achard <remiachard@gmail.com> --------- Signed-off-by: Rémi Achard <remiachard@gmail.com> Co-authored-by: Doug Walker <doug.walker@autodesk.com> Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix a couple of issues related to
GradingPrimarythat were found by @MrLixm, linked in the PR. The move of the equality operators to the public API are required for the Python bindings.I'm planning to look at other GradingPrimary related changes in a later PR, this one is only for bug fixes.